Repository navigation
fix(conductor): reject unsupported whole-branch review scopes - #236
Merged
Merged
Conversation
Require origin/main and a matching merge base before final reviews, and stop unsupported scopes without using the working-tree fallback. Document the restriction for users.
Codex Automated Code ReviewCode Review SummaryPR: Reject unsupported Conductor whole-branch review scopes by requiring P0 - Critical Issues (Must Fix)None found P1 - High Priority Issues (Should Fix)None found P2 - Medium Priority Issues (Consider Fixing)None found P3 - Low Priority Issues (Optional)None found Positive Observations
Automated review by OpenAI Codex |
foadshafighi
added a commit
that referenced
this pull request
Nov 13, 2026
Release /lp-conductor (#235, #236), the worktree commit-msg hook fix (#226), the move to the FrameworkedApp organization (#234) and the dependency and CI updates merged since v2.2.2. - Bump both plugin manifests to 2.3.0. - Move the unreleased changelog entries under v2.3.0 and add the plugin-internal changes. - Add docs/releases/v2.3.0.md. - Point the README version and release-notes link at v2.3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
/lp-conductorstop before a final whole-branch review that/lp-reviewcannot cover./lp-reviewalways compares againstorigin/main, and without it falls back to uncommitted files only, so a recorded review base elsewhere could produce a review that silently misses committed changes.Changes
origin/mainin the recorded Implementer repository andgit merge-base origin/main HEADequal to the recordedreview_base. Otherwise it stops with an unsupported-scope explanation and never accepts the working-tree fallback as a whole-branch review./lp-reviewitself is unchanged. An explicit base option for it is left to a separate change.Test plan
python -m pytest -qfromplugins/launchpad/scripts/(pre-push): 2439 passed, 5 skipped.pyright, Semgrep and the backlog check (pre-push).